Open
Conversation
6 tasks
pang-wu
force-pushed
the
pang/spark4
branch
7 times, most recently
from
21be2c9 to
1f04b26
Compare
rexminnis
reviewed
Feb 17, 2026
Contributor
rexminnis
left a comment
rexminnis
left a comment
There was a problem hiding this comment.
Thanks for putting this together — the CommandLineUtilsBridge pattern and the SparkSubmit rework are clean solutions to the cross-version API drift. A few things I noticed:
- Bug:
spark340/SparkSqlUtils.toArrowRDDhas infinite recursion (see inline comment) - Java target:
maven.compiler.sourceis still1.8— worth bumping to 17? - Spark version:
spark410.versiontargets 4.1.0 — consider 4.1.1 (current release)
Happy to help with testing or any of the shim work. I have a working Spark 4.1.1 setup locally and have been validating the Arrow conversion paths end-to-end.
core/shims/spark340/src/main/scala/org/apache/spark/sql/SparkSqlUtils.scala
Show resolved
Hide resolved
3 tasks
pang-wu
force-pushed
the
pang/spark4
branch
8 times, most recently
from
7acc670 to
c40d89d
Compare
1 task
pang-wu
force-pushed
the
pang/spark4
branch
2 times, most recently
from
26d576d to
ac217b9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adapt raydp with Spark 4.x but leave the following work for future improvement:
To make the tests pass, the PR is based on #458. Once PR#458 is merged this PR should rebase again.